Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support x_google_ignoreList in source map infra #973

Closed
wants to merge 1 commit into from

Conversation

motiz88
Copy link
Contributor

@motiz88 motiz88 commented Apr 24, 2023

Summary:
Changelog:

  • [Feature]: Basic support for x_google_ignoreList in metro-source-map and metro-symbolicate

Enables Metro's source map infrastructure to produce and consume the x_google_ignoreList field, documented here.

An upcoming diff will use this infra support to add ignore lists to Metro's source maps by default.

The changes here include:

  • An option to mark source files as ignored in metro-source-map's Generator (used by the serializer).
  • Preserving ignore lists in composeSourceMaps. composeSourceMaps is used by React Native in OSS to generate source maps for Hermes bytecode compiled from Metro bundles.
  • Including an isIgnored field in source locations returned via the metro-symbolicate API. metro-symbolicate is the reference implementation of symbolication based on Metro's source maps.

Differential Revision: D43554204

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Apr 24, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43554204

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43554204

motiz88 added a commit to motiz88/metro that referenced this pull request Apr 25, 2023
Summary:
Pull Request resolved: facebook#973

Changelog:
* **[Feature]**: Basic support for `x_google_ignoreList` in `metro-source-map` and `metro-symbolicate`

Enables Metro's source map infrastructure to produce and consume the `x_google_ignoreList` field, documented [here](https://developer.chrome.com/blog/devtools-better-angular-debugging/#the-x_google_ignorelist-source-map-extension).

An upcoming diff will use this infra support to add ignore lists to Metro's source maps by default.

The changes here include:

* An option to mark source files as ignored in `metro-source-map`'s `Generator` (used by the serializer).
* Preserving ignore lists in `composeSourceMaps`. `composeSourceMaps` is used by React Native in [OSS](https://github.com/facebook/react-native/blob/c1304d938da9cd5016da0bded4d618c42efbd7e4/scripts/compose-source-maps.js#L13) to generate source maps for Hermes bytecode compiled from Metro bundles.
* Including an `isIgnored` field in source locations returned via the `metro-symbolicate` API. `metro-symbolicate` is the reference implementation of symbolication based on Metro's source maps.

Reviewed By: GijsWeterings

Differential Revision: D43554204

fbshipit-source-id: f97255ec5272ad811e049c4db0c2ceca98dab3e2
Summary:
Pull Request resolved: facebook#973

Changelog:
* **[Feature]**: Basic support for `x_google_ignoreList` in `metro-source-map` and `metro-symbolicate`

Enables Metro's source map infrastructure to produce and consume the `x_google_ignoreList` field, documented [here](https://developer.chrome.com/blog/devtools-better-angular-debugging/#the-x_google_ignorelist-source-map-extension).

An upcoming diff will use this infra support to add ignore lists to Metro's source maps by default.

The changes here include:

* An option to mark source files as ignored in `metro-source-map`'s `Generator` (used by the serializer).
* Preserving ignore lists in `composeSourceMaps`. `composeSourceMaps` is used by React Native in [OSS](https://github.com/facebook/react-native/blob/c1304d938da9cd5016da0bded4d618c42efbd7e4/scripts/compose-source-maps.js#L13) to generate source maps for Hermes bytecode compiled from Metro bundles.
* Including an `isIgnored` field in source locations returned via the `metro-symbolicate` API. `metro-symbolicate` is the reference implementation of symbolication based on Metro's source maps.

Reviewed By: GijsWeterings

Differential Revision: D43554204

fbshipit-source-id: f49f65827ccb1d346eec192c81c53e39597025ab
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43554204

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in d8ca3f2.

fuxingloh pushed a commit to levaintech/keychain that referenced this pull request Jun 20, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [metro](https://github.com/facebook/metro) | [`0.76.0` ->
`0.76.6`](https://renovatebot.com/diffs/npm/metro/0.76.0/0.76.6) |
[![age](https://badges.renovateapi.com/packages/npm/metro/0.76.6/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/metro/0.76.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/metro/0.76.6/compatibility-slim/0.76.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/metro/0.76.6/confidence-slim/0.76.0)](https://docs.renovatebot.com/merge-confidence/)
|
| [metro-resolver](https://github.com/facebook/metro) | [`0.76.0` ->
`0.76.6`](https://renovatebot.com/diffs/npm/metro-resolver/0.76.0/0.76.6)
|
[![age](https://badges.renovateapi.com/packages/npm/metro-resolver/0.76.6/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/metro-resolver/0.76.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/metro-resolver/0.76.6/compatibility-slim/0.76.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/metro-resolver/0.76.6/confidence-slim/0.76.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>facebook/metro</summary>

###
[`v0.76.6`](https://github.com/facebook/metro/releases/tag/v0.76.6)

[Compare
Source](https://github.com/facebook/metro/compare/v0.76.5...v0.76.6)

- **\[Types]** Update config and `Server` types to use broader types
from `connect` package
(facebook/metro@d20d7c8
by [@&#8203;huntie](https://github.com/huntie))
- **\[Types]** Fix TypeScript name for `createConnectMiddleware` export
(facebook/metro@06682f8
by [@&#8203;huntie](https://github.com/huntie))
- **\[Deprecation]** Deprecate `server.enhanceMiddleware` option
(facebook/metro@22e85fd
by [@&#8203;huntie](https://github.com/huntie))

> NOTE: Experimental features are not covered by semver and can change
at any time.

- **\[Experimental]** Add `unstable_extraMiddleware` option to
`runServer` API
(facebook/metro@d0d5543
by [@&#8203;huntie](https://github.com/huntie))

**Full Changelog**:
facebook/metro@v0.76.5...v0.76.6

###
[`v0.76.5`](https://github.com/facebook/metro/releases/tag/v0.76.5)

[Compare
Source](https://github.com/facebook/metro/compare/v0.76.4...v0.76.5)

- **\[Feature]** Support URLs for both bundling and symbolication
requests using `//&` instead of `?` as a query string delimiter
(facebook/metro@bd357c8
by [@&#8203;robhogan](https://github.com/robhogan))
- **\[Fix]** Fix crash on a module added+modified+removed between
updates
(facebook/metro@5d7305e
by [@&#8203;robhogan](https://github.com/robhogan))
- **\[Fix]** Fix missed modification on module removed+modified+added
between updates
(facebook/metro@5d7305e
by [@&#8203;robhogan](https://github.com/robhogan))
- **\[Fix]** Emit source URLs in a format that will not be stripped by
JavaScriptCore
(facebook/metro@bce6b27ef8ac7c41e0a3e990eb71747cc0e6f606by
[@&#8203;robhogan](https://github.com/robhogan))
- **\[Performance]** Prune unmodified modules from delta updates before
sending them to the client
(facebook/metro@e24c6ae
by [@&#8203;robhogan](https://github.com/robhogan))

> NOTE: Experimental features are not covered by semver and can change
at any time.

- **\[Experimental]** Fix `babel/runtime` issue when using Package
Exports
(facebook/metro@905d773
by [@&#8203;huntie](https://github.com/huntie))

**Full Changelog**:
facebook/metro@v0.76.4...v0.76.5

###
[`v0.76.4`](https://github.com/facebook/metro/releases/tag/v0.76.4)

[Compare
Source](https://github.com/facebook/metro/compare/v0.76.3...v0.76.4)

- **\[Feature]**: Support the
[`x_google_ignoreList`](https://developer.chrome.com/articles/x-google-ignore-list/)
source map extension.
([facebook/metro#973,
[`82bd64a`](https://github.com/facebook/metro/commit/82bd64a9720174a9e2a02fb73bbef292153e20f1)
by [@&#8203;motiz88](https://github.com/motiz88))
- **\[Feature]**: Support bundling KTX files as image assets.
([facebook/metro#975
by [@&#8203;rshest](https://github.com/rshest))
- **\[Fix]**: Fix crash on a module added+modified+removed between
updates.
([`5d7305e`](https://github.com/facebook/metro/commit/5d7305e2f3a9f5f4aebc889a452afb03b1db12a7)
by [@&#8203;robhogan](https://github.com/robhogan))
- **\[Fix]**: Fix missed modification on module removed+modified+added
between updates.
([`5d7305e`](https://github.com/facebook/metro/commit/5d7305e2f3a9f5f4aebc889a452afb03b1db12a7)
by [@&#8203;robhogan](https://github.com/robhogan))

**Full Changelog**:
facebook/metro@v0.76.3...v0.76.4

###
[`v0.76.3`](https://github.com/facebook/metro/releases/tag/v0.76.3)

[Compare
Source](https://github.com/facebook/metro/compare/v0.76.2...v0.76.3)

- **\[Feature]**: Support custom `__loadBundleAsync` implementations in
the default `asyncRequire` function. See the [lazy bundling
RFC](https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md)
for more details.
(facebook/metro@ac3adce,
facebook/metro@f07ce5c
by [@&#8203;motiz88](https://github.com/motiz88))
- **\[Feature]**: Support `lazy` parameter in bundle requests. See the
[lazy bundling
RFC](https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md)
for more details.
(facebook/metro@4ef14f9
by [@&#8203;motiz88](https://github.com/motiz88))
- **\[Feature]**: Preserve comments in unminified builds, while
continuing to strip all comments from minified builds.
([facebook/metro#967
by [@&#8203;tido64](https://github.com/tido64))
- **\[Deprecated]**: The `transformer.asyncRequireModulePath` config
option is deprecated. Use
[`__loadBundleAsync`](https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md#\__loadbundleasync-in-metro)
instead.(facebook/metro@c7b684f
by [@&#8203;motiz88](https://github.com/motiz88))

> NOTE: Experimental features are not covered by semver and can change
at any time.

- **\[Experimental]** Package Exports unstable_conditionNames now
defaults to \['require', 'import']
(facebook/metro@e70ceef
by [@&#8203;huntie](https://github.com/huntie))
- **\[Experimental]** Removed `server.experimentalImportBundleSupport`
config option.
(facebook/metro@4ef14f9
by [@&#8203;motiz88](https://github.com/motiz88))

**Full Changelog**:
facebook/metro@v0.76.2...v0.76.3

###
[`v0.76.2`](https://github.com/facebook/metro/releases/tag/v0.76.2)

[Compare
Source](https://github.com/facebook/metro/compare/v0.76.1...v0.76.2)

- **\[Feature]**: Added customizeStack hook to Metro's `/symbolicate`
endpoint to allow custom frame skipping logic on a stack level.
(facebook/metro@ce266dd
by [@&#8203;GijsWeterings](https://github.com/GijsWeterings))
- **\[Feature]**: Re-export `metro-core`'s `Terminal` from `metro`.
(facebook/metro@86e3f93
by [@&#8203;robhogan](https://github.com/robhogan))
- **\[Feature]**: Re-export `metro-config`'s `resolveConfig` from
`metro`.
(facebook/metro@cc16664
by [@&#8203;robhogan](https://github.com/robhogan))
- **\[Types]**: Remove dependency on `@types/babel__code-frame`.
(facebook/metro@41cdc03
by [@&#8203;robhogan](https://github.com/robhogan))
- **\[Types]**: Remove dependency on `@types/ws`.
(facebook/metro@7deb525
by [@&#8203;robhogan](https://github.com/robhogan))
- **\[Types]**: Fix TypeScript types entry point for metro-source-map.
(facebook/metro@3238bbc
by [@&#8203;huntie](https://github.com/huntie))
- **\[Deprecated]**: Deprecate `ResolutionContext.getPackageForModule`.
(facebook/metro@2d0a01c
by [@&#8203;huntie](https://github.com/huntie))

> NOTE: Experimental features are not covered by semver and can change
at any time.

- **\[Experimental]**: Pass full path and query params to `asyncRequire`
for lazy bundles.
(facebook/metro@61a30b7
by [@&#8203;motiz88](https://github.com/motiz88))
- **\[Experimental]**: Fix bug where Package Exports warnings may have
been logged for nested `node_modules` path candidates.
(facebook/metro@29c77bf
by [@&#8203;huntie](https://github.com/huntie))
- **\[Experimental]**: Fix `package.json` discovery against root package
specifiers for Package Exports.
(facebook/metro@b995303
by [@&#8203;huntie](https://github.com/huntie), fixes
[facebook/metro#965
reported by [@&#8203;shamilovtim](https://github.com/shamilovtim))

**Full Changelog**:
facebook/metro@v0.76.1...v0.76.2

###
[`v0.76.1`](https://github.com/facebook/metro/releases/tag/v0.76.1)

[Compare
Source](https://github.com/facebook/metro/compare/v0.76.0...v0.76.1)

- **\[Feature]**: Support custom transformer/resolver options in `metro
build` and `runBuild` API.
(facebook/metro@fcfecc9
by [@&#8203;motiz88](https://github.com/motiz88))
- **\[Feature]**: `metro get-dependencies --entryFile <entryFile>` can
now be called as `metro get-dependencies <entryFile>`.
(facebook/metro@6fdce04
by [@&#8203;huntie](https://github.com/huntie))
- **\[Feature]**: Add `Content-Type` and `Content-Length` headers for
assets to Metro server.
([facebook/metro#953
by [@&#8203;aleqsio](https://github.com/aleqsio),
[facebook/metro#961
by [@&#8203;byCedric](https://github.com/byCedric))
- **\[Feature]**: Expose `mergeConfig` util from `metro` package.
(facebook/metro@aa8ec90
by [@&#8203;huntie](https://github.com/huntie))
- **\[Fix]**: `metro-file-map`: consistently abort crawl when `end()` is
called.
(facebook/metro@51877a8
by [@&#8203;motiz88](https://github.com/motiz88))
- **\[Fix]**: `metro-config`: Don't mutate argument to `loadConfig`.
(facebook/metro@38ec62d
by [@&#8203;motiz88](https://github.com/motiz88))
- **\[Fix]**: Babel transformers: Provide correct absolute source path
to plugins when Metro is not run from the project root.
(facebook/metro@de19bbd
by [@&#8203;robhogan](https://github.com/robhogan))
- **\[Fix]**:
[`resolver.assetExts`](https://facebook.github.io/metro/docs/configuration/#assetexts)
will now match asset files for extension values that include a dot
(`.`).
(facebook/metro@6d65a32
by [@&#8203;huntie](https://github.com/huntie))
- **\[Fix]**: Don't register an
[`unhandledRejection`](https://nodejs.org/api/process.html#event-unhandledrejection)
listener, fix spammy EventEmitter leak warning.
(facebook/metro@833f2ff
by [@&#8203;motiz88](https://github.com/motiz88))
- **\[Types]**: Add bundled TypeScript definitions (partial) for all
packages previously on DefinitelyTyped.
(facebook/metro@c022c36,
facebook/metro@07732e7,
facebook/metro@9ee5280
by [@&#8203;huntie](https://github.com/huntie), with
[@&#8203;afoxman](https://github.com/afoxman) and
[@&#8203;tido64](https://github.com/tido64))
- **\[Types]**: Expose `MetroConfig` type in `metro` package.
(facebook/metro@d2f3664
by [@&#8203;huntie](https://github.com/huntie))

> NOTE: Experimental features are not covered by semver and can change
at any time.

- **\[Experimental]**: Reorder `asyncRequire`'s parameters and make
module name optional.
(facebook/metro@4e5261c
by [@&#8203;motiz88](https://github.com/motiz88))
- **\[Experimental]**: Remove experimental `metro-hermes-compiler`
package.
(facebook/metro@833f2ff
by [@&#8203;motiz88](https://github.com/motiz88))
- **\[Experimental]**: Package Exports
[`unstable_conditionNames`](https://facebook.github.io/metro/docs/configuration/#unstable_conditionnames-experimental)
now defaults to `['require']`.
([facebook/metro#955
by [@&#8203;huntie](https://github.com/huntie))
- **\[Experimental]**: Add compatibility with legacy Node.js "exports"
array formats.
(facebook/metro@f321cff,
facebook/metro@1e47cb5
by [@&#8203;huntie](https://github.com/huntie))

**Full Changelog**:
facebook/metro@v0.76.0...v0.76.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/levaintech/keychain).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMzEuMCIsInVwZGF0ZWRJblZlciI6IjM1LjEzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants